Fix linting
Some checks failed
linter / quality (push) Failing after 6m26s
tests / ci (8.4) (push) Successful in 5m6s
tests / ci (8.5) (push) Successful in 5m38s

This commit is contained in:
2026-03-23 08:44:50 +01:00
parent 9d4b02fab5
commit ef90236adc
32 changed files with 123 additions and 113 deletions

View File

@@ -4,19 +4,13 @@ namespace Tests\Services\IterationEventBuffer;
use App\Services\IterationEventBuffer\IPerceptronIterationEventBuffer;
class DullIterationEventBuffer implements IPerceptronIterationEventBuffer {
class DullIterationEventBuffer implements IPerceptronIterationEventBuffer
{
public function __construct(
) {
) {}
}
public function flush(): void {}
public function flush(): void {
return;
}
public function addIteration(int $epoch, int $exampleIndex, float $error, array $synaptic_weights): void {
return;
}
public function addIteration(int $epoch, int $exampleIndex, float $error, array $synaptic_weights): void {}
}

View File

@@ -9,15 +9,14 @@ use Tests\Services\IterationEventBuffer\DullIterationEventBuffer;
class ADALINEPerceptronTest extends TrainingTestCase
{
public function test_adaline_perceptron_training_logic_and()
{
$training = new ADALINEPerceptronTraining(
datasetReader: new LinearOrderDataSetReader(public_path('data_sets/logic_and_gradient.csv')),
learningRate: 0.03,
maxEpochs: 10000,
synapticWeightsProvider: new ZeroSynapticWeights(),
iterationEventBuffer: new DullIterationEventBuffer(),
synapticWeightsProvider: new ZeroSynapticWeights,
iterationEventBuffer: new DullIterationEventBuffer,
sessionId: 'test-session',
trainingId: 'test-training',
minError: 0.1251,
@@ -57,8 +56,8 @@ class ADALINEPerceptronTest extends TrainingTestCase
datasetReader: new LinearOrderDataSetReader(public_path('data_sets/table_2_10.csv')),
learningRate: 0.0015,
maxEpochs: 1000,
synapticWeightsProvider: new ZeroSynapticWeights(),
iterationEventBuffer: new DullIterationEventBuffer(),
synapticWeightsProvider: new ZeroSynapticWeights,
iterationEventBuffer: new DullIterationEventBuffer,
sessionId: 'test-session',
trainingId: 'test-training',
// minError: 16.597077, // Impossible pour un dataset avec des labels -1 et 1 d'avoir une erreur moyenne supérieure à 2

View File

@@ -9,15 +9,14 @@ use Tests\Services\IterationEventBuffer\DullIterationEventBuffer;
class GradientDescentPerceptronTest extends TrainingTestCase
{
public function test_gradient_descent_perceptron_training_logic_and()
{
$training = new GradientDescentPerceptronTraining(
datasetReader: new LinearOrderDataSetReader(public_path('data_sets/logic_and_gradient.csv')),
learningRate: 0.2,
maxEpochs: 100,
synapticWeightsProvider: new ZeroSynapticWeights(),
iterationEventBuffer: new DullIterationEventBuffer(),
synapticWeightsProvider: new ZeroSynapticWeights,
iterationEventBuffer: new DullIterationEventBuffer,
sessionId: 'test-session',
trainingId: 'test-training',
minError: 0.125001,
@@ -56,8 +55,8 @@ class GradientDescentPerceptronTest extends TrainingTestCase
datasetReader: new LinearOrderDataSetReader(public_path('data_sets/table_2_10.csv')),
learningRate: 0.0015,
maxEpochs: 1000,
synapticWeightsProvider: new ZeroSynapticWeights(),
iterationEventBuffer: new DullIterationEventBuffer(),
synapticWeightsProvider: new ZeroSynapticWeights,
iterationEventBuffer: new DullIterationEventBuffer,
sessionId: 'test-session',
trainingId: 'test-training',
// minError: 16.388103, // Impossible pour un dataset avec des labels -1 et 1 d'avoir une erreur moyenne supérieure à 2

View File

@@ -9,15 +9,14 @@ use Tests\Services\IterationEventBuffer\DullIterationEventBuffer;
class SimplePerceptronTest extends TrainingTestCase
{
public function test_simple_perceptron_training_logic_and()
{
$training = new SimpleBinaryPerceptronTraining(
datasetReader: new LinearOrderDataSetReader(public_path('data_sets/logic_and.csv')),
learningRate: 1.0,
maxEpochs: 100,
synapticWeightsProvider: new ZeroSynapticWeights(),
iterationEventBuffer: new DullIterationEventBuffer(),
synapticWeightsProvider: new ZeroSynapticWeights,
iterationEventBuffer: new DullIterationEventBuffer,
sessionId: 'test-session',
trainingId: 'test-training',
);

View File

@@ -13,7 +13,6 @@ class TrainingTestCase extends TestCase
{
$training->start();
// Assert that the final synaptic weights are as expected withing the margin of error
// $finalWeights = $training->getSynapticWeights();
// $this->assertEqualsWithDelta($expectedWeights, $finalWeights, $marginOfError, "Final synaptic weights do not match expected values.");
@@ -21,5 +20,4 @@ class TrainingTestCase extends TestCase
// Assert that the number of epochs taken is as expected
$this->assertEquals($expectedEpochs, $training->getEpoch(), "Expected training to take $expectedEpochs epochs, but it took {$training->getEpoch()} epochs.");
}
}